Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run kubeflow-pipelines-tfx-python37 tests only on sdk/release-1.8 branch. #1843

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Run kubeflow-pipelines-tfx-python37 tests only on sdk/release-1.8 branch. #1843

merged 2 commits into from
Nov 24, 2022

Conversation

chensun
Copy link
Member

@chensun chensun commented Nov 23, 2022

TFX is not compatible with KFP SDK 2.0: https://github.com/tensorflow/tfx/blob/2450843564f4bc9297f01d1c8fd69c01c7dba4d8/tfx/dependencies.py#L133-L136

Installing KFP SDK from master head [ref] only would be reverted later when installing tfx [ref]. So we're not testing against master branch anyway.

@chensun
Copy link
Member Author

chensun commented Nov 23, 2022

/assign @connor-mccarthy

@chensun chensun mentioned this pull request Nov 23, 2022
Merged
1 task
@connor-mccarthy
Copy link
Member

/lgtm
/approve

Thanks for fixing this, @chensun!

@google-oss-prow google-oss-prow bot added the lgtm label Nov 24, 2022
@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, connor-mccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 6dcffcb into GoogleCloudPlatform:master Nov 24, 2022
@google-oss-prow
Copy link
Contributor

@chensun: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kubeflow-pipelines-presubmits.yaml using file prow/prowjobs/kubeflow/pipelines/kubeflow-pipelines-presubmits.yaml

In response to this:

TFX is not compatible with KFP SDK 2.0: https://github.com/tensorflow/tfx/blob/2450843564f4bc9297f01d1c8fd69c01c7dba4d8/tfx/dependencies.py#L133-L136

Installing KFP SDK from master head [ref] only would be reverted later when installing tfx [ref]. So we're not testing against master branch anyway.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chensun chensun deleted the patch-2 branch November 24, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-jwu james-jwu Awaiting requested review from james-jwu

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@connor-mccarthy connor-mccarthy

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chensun @connor-mccarthy